~starkingdoms/starkingdoms

ref: 34e4a91c02854609d8c922d8a9a0a7963bb6a9dd starkingdoms/crates/unified/src/server/player.rs -rw-r--r-- 20.5 KiB
34e4a91c — core fix: detachment 26 days ago
                                                                                
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
pub mod join;

use crate::attachment::{Joint, JointOf, Joints, PartInShip, Peer, SnapOf, SnapOfJoint};
use crate::config::planet::Planet;
use crate::ecs::{DragRequestEvent, Part, Player, PlayerStorage, PlayerThrust, ThrustEvent};
use crate::server::part::SpawnPartRequest;
use crate::server::system_sets::PlayerInputSet;
use crate::server::world_config::WorldConfigResource;
use crate::server::{ConnectedGameEntity, ConnectedNetworkEntity};
use crate::prelude::*;
use bevy_replicon::prelude::{ClientId, FromClient};
use std::f32::consts::PI;
use crate::config::world::GlobalWorldConfig;

pub fn player_management_plugin(app: &mut App) {
    app.add_systems(
        Update,
        (
            join::handle_pending_players,
            join::handle_new_players,
            player_thrust,
            magic_fuel_regen,
            dragging,
        )
            .in_set(PlayerInputSet),
    );
    app.add_systems(Update, complete_partial_disconnects);
}

#[derive(Component)]
struct PartiallyDisconnected;

/// Partial Disconnects are created when a part is disconnected to indicate that a disconnect has started.
/// Disconnects cannot be completed until the next tick, after relevant Peer relationships have been removed.
/// This system does this by performing a flood search to determine if the 'partial-disconnected' parts still have
/// a valid path to hearty; if they do not, they are removed from the ship.
fn complete_partial_disconnects(
    partial_disconnected_parts: Query<Entity, With<PartiallyDisconnected>>,
    mut q_joints: Query<&Joints>,
    mut q_maybe_peer: Query<Option<&Peer>>,
    mut q_joint_of_part: Query<&JointOf>,
    mut q_is_hearty: Query<Option<&Player>>,
    mut dc_q_joints: Query<(&Joint, &JointOf, &Transform, Option<&Peer>, Entity)>,
    mut dc_q_only_joints: Query<&Joints>,

    mut commands: Commands,
) {
    for partially_disconnected_part in &partial_disconnected_parts {

        trace!(?partially_disconnected_part, "completing partial disconnect from previous tick");
        commands.entity(partially_disconnected_part).remove::<PartiallyDisconnected>();

        // is it still connected to hearty?
        let mut search_visited_joints = vec![];
        let can_reach_hearty = can_reach_hearty(
            partially_disconnected_part,
            q_joints.reborrow(),
            q_maybe_peer.reborrow(),
            q_joint_of_part.reborrow(),
            q_is_hearty.reborrow(),
            &mut search_visited_joints,
            true
        );
        if can_reach_hearty {
            // great, leave them alone
            continue;
        }
        // this part cannot reach hearty
        // trigger a disconnect on them to propagate the disconnection

        let mut disconnect_queue = vec![];
        commands.entity(partially_disconnected_part).remove::<PartInShip>(); // they're no longer in the ship, remove them from the meta
        disconnect_part(
            (partially_disconnected_part, match q_joints.get(partially_disconnected_part) {
                Ok(j) => j,
                Err(e) => {
                    warn!(?partially_disconnected_part, "part does not have a Joints? this should be impossible...");
                    continue;
                }
            }),
            &dc_q_joints,
            &dc_q_only_joints,
            &mut disconnect_queue,
            commands.reborrow()
        );
        commands.entity(partially_disconnected_part).remove::<PartiallyDisconnected>();
    }
}

/// Determine if a part has a path to hearty by performing a depth-first search
/// TODO: This can be very slow on large ships- the path propagation model will be significantly faster
/// TODO: Ask core for an explanation of what the path propagation model is if you want to implement this
fn can_reach_hearty(
    part: Entity,

    mut q_joints: Query<&Joints>,
    mut q_maybe_peer: Query<Option<&Peer>>,
    mut q_joint_of_part: Query<&JointOf>,
    mut q_is_hearty: Query<Option<&Player>>,

    mut visited_joints: &mut Vec<Entity>,

    is_top_of_recursion: bool
) -> bool {
    // Are we hearty?
    if let Ok(Some(_)) = q_is_hearty.get(part) {
        debug!("partial detach DFS: visited {} joints => we are hearty! @ {:?}", visited_joints.len(), part);
        return true;
    }

    // Get the joints of this entity
    let Ok(our_joints) = q_joints.get(part).cloned() else {
        warn!("part does not have a Joints? this should be impossible...");
        return false;
    };

    // Iterate over each joint:
    // if it's Hearty: great! we're connected
    // if it's another part: recurse to it
    // if it's not connected: lame, move on
    'to_next_joint: for joint in &**our_joints {
        // mark that we've visited this joint, so we don't come back to it later
        visited_joints.push(*joint);

        // does this joint have a peer?
        let maybe_peer = q_maybe_peer.get(*joint).expect("cannot fail");

        if let Some(peer_info) = maybe_peer {
            // we have a peer! figure out what it's connected to...
            let other_parts_joint = peer_info.peer_joint_entity_id;
            // have we visited this joint already?
            if visited_joints.contains(&other_parts_joint) {
                // if so, move on
                continue 'to_next_joint;
            }
            // we have not, find it's parent part
            let other_part = q_joint_of_part.get(other_parts_joint).expect("joint is missing JointOf").0;
            // is this part Hearty?
            let maybe_is_hearty = q_is_hearty.get(other_part).expect("cannot fail");
            if maybe_is_hearty.is_some() {
                // yay! found hearty
                debug!("partial detach DFS: visited {} joints => found hearty @ {:?}", visited_joints.len(), other_part);
                debug!("-> via {:?}", part);
                return true;
            } else {
                // not hearty. but can the other part reach hearty?
                let can_other_part_reach = can_reach_hearty(
                    other_part,
                    q_joints.reborrow(),
                    q_maybe_peer.reborrow(),
                    q_joint_of_part.reborrow(),
                    q_is_hearty.reborrow(),
                    visited_joints,
                    false
                );
                if can_other_part_reach {
                    // great, they are connected
                    // log that we're in the path, then bubble up
                    debug!("-> via {:?}", part);
                    return true;
                } else {
                    // lame. continue to next part, and remove PartInShip as they're not connected anymore
                    continue 'to_next_joint;
                }
            }
        } else {
            // we do not have a peer. move on
            continue 'to_next_joint;
        }
    }

    // Exhausted all options; we are not connected to hearty bubble up
    if is_top_of_recursion {
        // print a debug message
        debug!("partial detach DFS: visited {} joints => not connected", visited_joints.len());
    }
    false
}



fn disconnect_part(
    (entity, joints): (Entity, &Joints),
    q_joints: &Query<(&Joint, &JointOf, &Transform, Option<&Peer>, Entity)>,
    q_only_joints: &Query<&Joints>,
    processed_peers: &mut Vec<Entity>,
    mut commands: Commands,
) {
    //trace!(?entity, ?joints, ?processed_peers, "recursive disconnect");
    // loop the joints in the entity
    for joint in joints.iter() {
        // now we have the entity "joint"
        let Ok((_, _, _, peer, _)) = q_joints.get(joint) else {
            continue;
        };
        // don't want to double process a joint
        if processed_peers.contains(&joint) { continue; }

        // we have the peer that holds the physics joint
        let Some(peer) = peer else { continue; };
        commands.entity(joint).remove::<Peer>();
        processed_peers.push(joint);

        let mut physics_joint = commands.entity(peer.physics_joint);
        // the physics joint shouldnt exist anymore
        physics_joint.despawn();

        // delete the other side's peer that exists for some reason
        let Ok((_, other_joint_of, _, other_peer, _)) = q_joints.get(peer.peer_joint_entity_id) else {
            continue;
        };
        let Some(other_peer) = other_peer else { continue; };
        commands.entity(peer.peer_joint_entity_id).remove::<Peer>();

        let Ok(other_joints) = q_only_joints.get(other_joint_of.0) else {
            continue
        };
        //commands.entity(other_joint_of.0).remove::<PartInShip>();

        if !processed_peers.contains(&peer.peer_joint_entity_id) {
            disconnect_part((other_joint_of.0, joints), q_joints,
                q_only_joints, processed_peers, commands.reborrow());
        }

        processed_peers.push(peer.peer_joint_entity_id);
    }
    // recursive disconnect part
    //commands.entity(entity).remove::<PartInShip>();
    commands.entity(entity).insert(PartiallyDisconnected);
}

fn dragging(
    mut events: MessageReader<FromClient<DragRequestEvent>>,
    mut parts: Query<
        (
            &mut Transform,
            Option<&PartInShip>,
            Entity,
            &mut LinearVelocity,
            &Joints,
            &mut AngularVelocity,
            &Part,
        ),
        (Without<Joint>),
    >,
    snaps: Query<(&SnapOf, &SnapOfJoint)>,
    joints: Query<(&Joint, &JointOf, &Transform, Option<&Peer>, Entity)>,
    peer: Query<(Entity, &Peer, &JointOf)>,
    q_joints: Query<&Joints>,
    q_joint: Query<&FixedJoint>,
    clients: Query<&ConnectedNetworkEntity>,
    q_ls_me: Query<Entity, With<crate::client::Me>>,
    mut commands: Commands,
) {
    for FromClient {
        client_id,
        message: event,
    } in events.read()
    {
        let player_hearty_entity = match client_id {
            ClientId::Client(client_entity) => {
                let ConnectedNetworkEntity {
                    game_entity: player_hearty_entity,
                } = clients.get(*client_entity).unwrap();
                player_hearty_entity
            },
            ClientId::Server => &q_ls_me.iter().next().unwrap()
        };

        debug!(?event, "got drag request event");

        let mut teleport_to_translation = Vec2::new(0.0, 0.0);
        let mut teleport_to_rotation = Quat::from_rotation_z(0.0);
        let mut new_linvel = None;
        let mut new_angvel = None;

        if let Some(snap_to) = event.snap_target
            && let Some(peer_snap) = event.peer_snap
        {
            let Ok(snap_on_target) = snaps.get(snap_to) else {
                continue;
            };
            let Ok(snap_on_source) = snaps.get(peer_snap) else {
                continue;
            };

            let Ok(target_joint) = joints.get(snap_on_target.1.0) else {
                continue;
            };
            let Ok(source_joint) = joints.get(snap_on_source.1.0) else {
                continue;
            };

            // validation step 1: everything must match. if not, ignore the request
            if snap_on_target.0.0 != target_joint.1.0 {
                warn!(
                    "drag request: mismatched target entities (potential manipulation?), ignoring"
                );
                continue;
            }
            if snap_on_source.0.0 != source_joint.1.0 {
                warn!(
                    "drag request: mismatched source entities (potential manipulation?), ignoring request"
                );
                continue;
            }

            // we've passed initial validation.
            // do not allow drags with the source or destination if they already have a peer (are attached)
            if target_joint.3.is_some() {
                warn!(
                    "drag request: cannot attach to a joint that already has a peer, ignoring request"
                );
                continue;
            }
            if source_joint.3.is_some() {
                warn!(
                    "drag request: dragging from a part that is already attached is currently not supported, ignoring request"
                );
                continue;
            }

            // great, the attachment appears to be valid
            // let's make sure this player is allowed to drag onto this part
            // getting attached to (hearty)
            let target_part = {
                let Ok(target_part) = parts.get(target_joint.1.0) else {
                    continue;
                };
                target_part
            };

            // attached (housing)
            let source_part = {
                let Ok(source_part) = parts.get(source_joint.1.0) else {
                    continue;
                };
                source_part
            };

            let allowed = target_joint.1.0 == *player_hearty_entity
                || target_part.1.is_some_and(|u| u.0 == *player_hearty_entity);
            if !allowed {
                warn!("drag request: this player cannot move this part, ignoring request");
                continue;
            }

            // TODO - validate source_part?

            // great, we have a valid peering request

            let did_disconnect = q_joint.get(source_part.2).is_ok();
            let mut processed = vec![source_joint.4];
            disconnect_part(
                (source_part.2, source_part.4),
                &joints,
                &q_joints,
                &mut processed,
                commands.reborrow(),
            );

            // create the joint...
            let joint = FixedJoint::new(target_part.2, source_part.2)
                .with_local_anchor1(target_joint.2.translation.xy())
                .with_local_basis1(target_joint.0.transform.rotation.to_euler(EulerRot::ZYX).0 + PI
                    - source_joint.0.transform.rotation.to_euler(EulerRot::ZYX).0);

            let joint_id = commands.spawn(joint).id();

            // create the peering component...
            commands.entity(source_joint.4).insert(Peer {
                peer_joint_entity_id: target_joint.4,
                processed: true,
                physics_joint: joint_id
            });
            commands.entity(target_joint.4).insert(Peer {
                peer_joint_entity_id: source_joint.4,
                processed: true,
                physics_joint: joint_id
            });

            // propagate PartInShip...

            let part_in_ship = if target_joint.1.0 == *player_hearty_entity {
                PartInShip(*player_hearty_entity)
            } else {
                PartInShip(target_part.1.unwrap().0) // unwrap: checked above (during 'allowed' calculation)
            };

            commands.entity(source_part.2).insert(part_in_ship);

            let target_position = target_part.0.mul_transform(*target_joint.2);

            let rotation = event.set_rotation.to_scaled_axis().z;
            let rotation = Rot2::radians(rotation);

            teleport_to_translation = target_position.translation.xy();
            teleport_to_rotation = target_position.rotation
                * source_joint.0.transform.rotation.inverse()
                * Quat::from_rotation_z(PI);
            new_linvel = Some(*target_part.3);
            new_angvel = Some(*target_part.5);
            // and we're done!
        } else {
            warn!(
                "blindly accepting non-attachment request, someone should change this eventually"
            );
            warn!("dragging already attached entities may cause inconsistent behavior!!");
            let source_part = parts.get(event.drag_target).unwrap();
            let mut processed = vec![];
            disconnect_part(
                (source_part.2, source_part.4),
                &joints,
                &q_joints,
                &mut processed,
                commands.reborrow(),
            );
            teleport_to_translation = event.drag_to;
            teleport_to_rotation = event.set_rotation;
        }

        let mut part = parts.get_mut(event.drag_target).unwrap();
        debug!("{:?} {:?}", part.0.translation, teleport_to_translation);
        part.0.translation.x = teleport_to_translation.x;
        part.0.translation.y = teleport_to_translation.y;
        debug!("{:?} {:?}", part.0.translation, teleport_to_translation);
        part.0.rotation = teleport_to_rotation; // client calculates this; no reason to recalculate
        if let Some(new_vel) = new_linvel {
            *part.3 = new_vel;
        }
        if let Some(new_vel) = new_angvel {
            *part.5 = new_vel;
        }
        // ( the math sucks )
    }
}



fn magic_fuel_regen(players: Query<&mut PlayerStorage, With<Player>>, time: Res<Time>) {
    for mut storage in players {
        storage.fuel = (storage.fuel + 5.0 * time.delta_secs()).min(storage.fuel_capacity);
    }
}

fn player_thrust(
    mut players: Query<(
        &Transform,
        &Part,
        &mut ConstantForce,
        &mut PlayerThrust,
        &mut PlayerStorage,
    )>,
    clients: Query<&ConnectedNetworkEntity>,
    mut thrust_event: MessageReader<FromClient<ThrustEvent>>,
    q_ls_me: Query<Entity, With<crate::client::Me>>,
    world_config: Res<WorldConfigResource>,
) {
    for FromClient {
        client_id,
        message: event,
    } in thrust_event.read()
    {
        let player_hearty_entity = match client_id {
            ClientId::Client(client_entity) => {
                let ConnectedNetworkEntity {
                    game_entity: player_hearty_entity,
                } = clients.get(*client_entity).unwrap();
                player_hearty_entity
            },
            ClientId::Server => &q_ls_me.iter().next().unwrap()
        };

        let Ok((_, _, _, mut thrust, _)) = players.get_mut(*player_hearty_entity) else {
            continue;
        };

        match *event {
            ThrustEvent::Up(on) => thrust.up = on,
            ThrustEvent::Down(on) => thrust.down = on,
            ThrustEvent::Left(on) => thrust.left = on,
            ThrustEvent::Right(on) => thrust.right = on,
        }
    }
    for (transform, part, force, thrust, storage) in &mut players {
        let Some(world_config) = &world_config.config else {
            return;
        };

        let forward = (transform.rotation * Vec3::Y).xy();
        let external_force = ConstantForce::default();

        // indices are quadrants:
        // 1 | 0
        // --+--
        // 2 | 3
        //
        let mut thrusters = [0.0; 4];

        if thrust.up {
            thrusters[1] = 1.0;
            thrusters[2] = 1.0;
        }
        if thrust.down {
            thrusters[0] = 1.0;
            thrusters[3] = 1.0;
        }
        if thrust.left {
            thrusters[0] = 1.0;
            thrusters[2] = 1.0;
        }
        if thrust.right {
            thrusters[1] = 1.0;
            thrusters[3] = 1.0;
        }

        // prevent fuel wasting when turning while moving forward/reverse
        if thrusters[2] == thrusters[3] && thrusters[3] != 0.0 {
            (thrusters[2], thrusters[3]) = (0.0, 0.0);
        }
        if thrusters[0] == thrusters[1] && thrusters[1] != 0.0 {
            (thrusters[0], thrusters[1]) = (0.0, 0.0);
        }

        let half_size = Vec2::new(
            world_config.part.default_width / 2.0,
            world_config.part.default_height / 2.0,
        )
        .length();

        // TODO: TF does this mess even do?
        /*
        external_force += ConstantForce::at_point(
            -forward * thrusters[0] * world_config.hearty.thrust,
            transform.translation.xy()
                + half_size
                    * Vec2::new((1.0 * PI / 4.0).cos(), (1.0 * PI / 4.0).sin()).rotate(forward),
            transform.translation.xy(),
        );
        external_force += ConstantForce::at_point(
            forward * thrusters[1] * world_config.hearty.thrust,
            transform.translation.xy()
                + half_size
                    * Vec2::new((3.0 * PI / 4.0).cos(), (3.0 * PI / 4.0).sin()).rotate(forward),
            transform.translation.xy(),
        );
        external_force += ConstantForce::at_point(
            forward * thrusters[2] * world_config.hearty.thrust,
            transform.translation.xy()
                + half_size
                    * Vec2::new((5.0 * PI / 4.0).cos(), (5.0 * PI / 4.0).sin()).rotate(forward),
            transform.translation.xy(),
        );
        external_force += ConstantForce::at_point(
            -forward * thrusters[3] * world_config.hearty.thrust,
            transform.translation.xy()
                + half_size
                    * Vec2::new((7.0 * PI / 4.0).cos(), (7.0 * PI / 4.0).sin()).rotate(forward),
            transform.translation.xy(),
        );
        *force += external_force;

        storage.fuel -=
            thrusters.iter().sum::<f32>() * part.strong_config.thruster.as_ref().unwrap().flow_rate;*/
    }
}